Closed Bug 1011687 Opened 10 years ago Closed 10 years ago

[Flame][Calendar] - Fuzzy images

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pivanov, Assigned: pivanov, NeedInfo)

References

Details

Attachments

(4 files)

patch for Gaia/master
46 bytes, text/x-github-pull-request
gaye
: review+
Details | Review
fuzzy_calendar_gear.png
23.54 KB, image/png
Details
missing images.zip
137.53 KB, application/zip
Details
swipe_left@2.25x.png
8.93 KB, image/png
Details 
      No description provided.
Attached file patch for Gaia/master — 

        Attachment #8424116 -
        Flags: review?(gaye)

    
    

    
  
What is the bug?

    
    

    
  

      
      
      
      

        Attached file
          
        missing images.zip
        — 
      

    


  
Hi Pavel,

I checked output list which you provide, and try to update some images,please see attached file. 
updated these missing images

./apps/calendar/style/icons/check_mark_on@1.5x.png
./apps/calendar/style/icons/check_mark_on@2x.png
./apps/calendar/style/icons/check_mark_on@2.25x.png
./apps/calendar/style/icons/check_mark_press@1.5x.png
./apps/calendar/style/icons/check_mark_press@2x.png
./apps/calendar/style/icons/check_mark_press@2.25x.png
./apps/calendar/style/icons/refresh@2.25x.png
./apps/calendar/style/icons/refresh_press@2.25x.png
./apps/calendar/style/icons/settings_icon@2.25x.png
./apps/calendar/style/icons/settings_icon_press@2.25x.png
./apps/calendar/style/icons/update@2x.png
./apps/calendar/style/icons/update@2.25x.png

-------------------------------------------------

    
    

    
  
these icon as below were already exists but with wrong file names
for example, Calendar_60.png is 1x image,Calendar_120.png is 2x image
so there won't be "Calendar_120@1.5x.png" "Calendar_120@2x.png" "Calendar_120@2.25x.png" in the assets.

./apps/calendar/style/icons/Calendar_120@1.5x.png
./apps/calendar/style/icons/Calendar_120@2x.png
./apps/calendar/style/icons/Calendar_120@2.25x.png
./apps/calendar/style/icons/Calendar_135@1.5x.png
./apps/calendar/style/icons/Calendar_135@2x.png
./apps/calendar/style/icons/Calendar_135@2.25x.png
./apps/calendar/style/icons/Calendar_60@1.5x.png
./apps/calendar/style/icons/Calendar_60@2x.png
./apps/calendar/style/icons/Calendar_60@2.25x.png
./apps/calendar/style/icons/Calendar_90@1.5x.png
./apps/calendar/style/icons/Calendar_90@2x.png
./apps/calendar/style/icons/Calendar_90@2.25x.png

-------------------------------------------------

    
    

    
  
Thanks Peko :)
I just updated the patch.

    
    

    
  
and for the rest part

./apps/calendar/style/ui/drawer@1.5x.png
./apps/calendar/style/ui/drawer@2x.png
./apps/calendar/style/ui/drawer@2.25x.png
./apps/calendar/style/ui/drawer_shadow@1.5x.png
./apps/calendar/style/ui/drawer_shadow@2.25x.png
./apps/calendar/style/ui/header@1.5x.png
./apps/calendar/style/ui/header@2x.png
./apps/calendar/style/ui/header@2.25x.png
./apps/calendar/style/ui/progress@1.5x.png
./apps/calendar/style/ui/progress@2x.png
./apps/calendar/style/ui/progress@2.25x.png
./apps/calendar/style/ui/shadow-header@1.5x.png
./apps/calendar/style/ui/shadow-header@2.25x.png

I think these images are old version,we won't use these images for visual refresh.Still need to confirm with RD.

thanks you~~

    
    

    
  
please help to rename files 
Calendar_60.png to calendar.png
Calendar_90.png to calendar@1.5x.png
Calendar_120.png to calendar@2x.png
Calendar_135.png to calendar@2.25x.png
thank you so much

(In reply to Peko Chen [:peko] from comment #6)
> these icon as below were already exists but with wrong file names
> for example, Calendar_60.png is 1x image,Calendar_120.png is 2x image
> so there won't be "Calendar_120@1.5x.png" "Calendar_120@2x.png"
> "Calendar_120@2.25x.png" in the assets.
> 
> ./apps/calendar/style/icons/Calendar_120@1.5x.png
> ./apps/calendar/style/icons/Calendar_120@2x.png
> ./apps/calendar/style/icons/Calendar_120@2.25x.png
> ./apps/calendar/style/icons/Calendar_135@1.5x.png
> ./apps/calendar/style/icons/Calendar_135@2x.png
> ./apps/calendar/style/icons/Calendar_135@2.25x.png
> ./apps/calendar/style/icons/Calendar_60@1.5x.png
> ./apps/calendar/style/icons/Calendar_60@2x.png
> ./apps/calendar/style/icons/Calendar_60@2.25x.png
> ./apps/calendar/style/icons/Calendar_90@1.5x.png
> ./apps/calendar/style/icons/Calendar_90@2x.png
> ./apps/calendar/style/icons/Calendar_90@2.25x.png
> 
> -------------------------------------------------

    
    

    
  
Hey Peko,
I update the PR again. What about https://bugzilla.mozilla.org/show_bug.cgi?id=1011687#c8 ?Who can we ask for this?

    
    

    
  
Hi Pavel,

I remember James Burke(jrburke@gmail.com) is doing drawer,so maybe we can ask him for this : )

(In reply to Pavel Ivanov [:ivanovpavel] from comment #10)
> Hey Peko,
> I update the PR again. What about
> https://bugzilla.mozilla.org/show_bug.cgi?id=1011687#c8 ?Who can we ask for
> this?

    
    

    
  
Hey James can you help here?
Flags: needinfo?(jburke)

    
    

    
  

      
      
      
      

        Attached image
          
        swipe_left@2.25x.png
        — 
      

    


  
upload a missing image
./apps/calendar/style/ui/swipe_left@2.25x.png
please help to update it.
thank you so much.

    
    

    
  
Done :)

    
    

    
  
This has been waiting for review since mid May. We need to start landing these patches in master for testing as Sprint 3 draws to a close this Friday. Flagging Adam on Calendar to see if we can get this review moving.
Flags: needinfo?(arogers)

    
  
Flags: needinfo?(arogers) → needinfo?(wmathanaraj)

    
    

    
  
Going to look at this today. Sorry for delay... was on PTO.

    
    

    
  
Comment on attachment 8424116 [details] [review]
patch for Gaia/master

LGTM thanks!

        Attachment #8424116 -
        Flags: review?(gaye) → review+
Flags: needinfo?(wmathanaraj) → needinfo?(skasetti)

    
    

    
  
Landed on master:
https://github.com/mozilla-b2g/gaia/commit/0410f2a60cd68ebf0e3f5151404fefe38d1ad5df
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
  
Flags: needinfo?(skasetti)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: